Bug 925 - [Chameleon - Widget] Popup assumes invalid attribute in SharedResource
: [Chameleon - Widget] Popup assumes invalid attribute in SharedResource
Status: RESOLVED FIXED
: Chameleon
Widget
: 2.2
: All All
: P1 minor
: ---
Assigned To:
:
:
:
:
:
  Show dependency treegraph
 
Reported: 2005-01-13 17:35 by
Modified: 2005-09-27 15:59 (History)


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2005-01-13 17:35:55
Noted by -Ken-ichi ...

Hi all.  I'm trying to set the PopupCSS SharedResource like this

<cwc2 type="SharedResource" name="PopupCSS"
value="/absolute/or/relative/path/to/popup.css"/>

but I get this warning

WARNING: following attributes are invalid for a sharedresource widget: VALUE.
The widget tag was: <cwc2 type="SharedResource" name="PopupCSS"
value="/absolute/or/relative/path/to/popup.css"/>

I'm running Chameleon 2.0.  Was the syntax for this changed for 2.0, or am I
missing something?

My repsonse:

Opps.  The issue here is that Chameleon will now emit warnings if you use
invalid attributes in widgets.  In this case, VALUE is not declared as an
official attribute of the SharedResource widget, hence the warning.  However,
the Popup.php code assumes that value is set.  Right now, if you didn't include
an errorreport widget, all would work wonderfully and you just wouldn't see the
warning.

The quick fix is to add the VALUE attribute to SharedResource.  I'm not sure if
that is the right fix, however.  I'll give it some thought and commit a fix shortly.
------- Comment #1 From 2005-07-12 08:07:36 -------
I think the right way to fix this bug is to change the structure of the popup
shared resource so that there is a subtag, as in:

<cwc2 type="SharedResource" name="PopupCSS">
    <url value="<url to css file"/>
</cwc2>

We will need to make sure that the code checks both the new case and the old
case (value="" in the cwc2 tag) in 2.3/2.4 and then we could eventually remove
it in the following version.  In the current version, we need to emit an error
if the old value="" in the cwc2 tag is used.  In the next version, we can remove
those checks.

Ideally, we would also change the Popup.php so that you could specify the name
of the shared resource to use, popupcssresource="MyPopupCSS", but that is a less
critical change at this point.
------- Comment #2 From 2005-07-12 08:20:27 -------
*** Bug 1110 has been marked as a duplicate of this bug. ***
------- Comment #3 From 2005-09-27 15:59:27 -------
Popup now use the URL subtag in the Shared Resource PopupCSS.
<cwc2 type="SharedResource" name="PopupCSS">
    <url value="<url to css file>"/>
</cwc2>

It still support the VALUE in the shared resource tag. However, an error is
returned.

Marking as FIXED