do for RC1.

accepted for RC1.

need to implement widget name deprecation system.

done in cvs.  MapDHTMLWidget was moved to MapDHTML and all files updated.  The
new widget renaming architecture is in place.

MapDHTMLWidget will work in version 1.99, 2.0 and 2.1.  In version 2.2, a
warning will be triggered.  In version 2.4, an error will occur.

To test this, change the defined version numbers in chameleon.php (new addition
for this bug).  If you want to change something, please read comments in
chameleon.php and WidgetManager.php before telling me it doesn't work.

I tested it by setting the version to 2.2 inside chameleon.php:  a warning pops
up-->great.

I set the version to 2.4:  an error pops up-->excellent.

I set the version to 2.5:  no more warning, no more error.  I thing an error
should pop up.

Chameleon CVS 20041202.

Ok, I am dead.  I read in WidgetManager.php again.  No error message should
appear but widget should appear in RED in the template.  That's ok.  But I tried
that and it didn't appear in RED.

If I change the defines to:

define( "CHAMELEON_MAJOR_VERSION", "2" );
define( "CHAMELEON_MINOR_VERSION", "5" );
define( "CHAMELEON_POINT_VERSION", "0" );
define( "CHAMELEON_STATE_VERSION", "" );

in chameleon.php and then load sample_basic.phtml, I get the MapDHTMLWidget tag
in red AND an error report popup that says there is no such widget as MapDHTMLWidget

what did you do that was different?

I made this setting:

define( "CHAMELEON_MAJOR_VERSION", "2" );
define( "CHAMELEON_MINOR_VERSION", "5" );
define( "CHAMELEON_POINT_VERSION", "0" );
define( "CHAMELEON_STATE_VERSION", "beta3" );

I used the same application that you used.

If I try this setting:


define( "CHAMELEON_MAJOR_VERSION", "2" );
define( "CHAMELEON_MINOR_VERSION", "4" );
define( "CHAMELEON_POINT_VERSION", "0" );
define( "CHAMELEON_STATE_VERSION", "beta3" );

I got an error message but no RED link.

(I updated both chameleon and php_utils)

More info:

I still have the MapDHTMLWidget directory under chameleon/htdocs/widgets
directory (I think it is what we expected from a user installation).  (Also I
don't know if it has an impact but the maturity level for this widget and the
MapDHTML widget is still BETA).

I asked Julien to test this issue.  He still have the MapDHTMLWidget directory
as well (MapDHTMLWidget maturity level not set, MapDHTML maturity level set to
BETA and Chameleon maturity level set to BETA).  He got the following results:

Chameleon version                         result
2.1, 2.2              Widget deprecated warning + map appears 
2.3, 2.4              Widget deprecated warning + NO map + maturity level error
2.5                   NO map + maturity level error

He never got the RED link.

Question:

Should Chameleon check for the maturity level first and then check for the
widget deprecation after?

What will be the scenario for Chameleon future release in relation with widget
deprecation e.g. MapDHTMLWidget:?  Will it be:

-Version 2.2:  MapDHTMLWidget directory still there and a warning appears and
-Version 2.4:  MapDHTMLWidget directory removed and an error message appears?

The MapDHTMLWidget directory has already been removed (as with the other
deprecated widgets) and they will not be distributed with the next version.  The
only people who will run into this problem are the cvs users, and my email on
this subject was fairly clear about having to manually remove this directory. 
Also, if you pay close attention to your cvs update, it will tell you that there
is a problem with the MapDHTMLWidget directory as it has a CVS subdirectory but
the server knows nothing about it.

I have tested with your exact defines (and no MapDHTMLWidget directory) and it
works for me.  Since version 2.4 is a long way in the future, I do not expect
this to be an issue and I am not going to try to detect it.  Please remove the
MapDHTMLWidget directory and retest.

For Chris' eyes only.  Please Chris when you have some time verify that you
obtain the same results.

I checkout a new fresh version of Chameleon and php_utils.  I checked under
chameleon/htdocs/widgets and there is no MapDHTMLWidget directory.

Version                                    Result
1.99                          No message + MapDHTMLWidget working
2.0,2.1,2.2                   Warning + MapDHTMLWidget working
2.3,2.4                       Two errors + RED link
2.5                           One error + RED link








-----------
Version 2.0, 2.1, 2.2 message:

WARNING: MapDHTMLWidget has been renamed to MapDHTML. Please update your template.


Version 2.3, 2.4 messages:

    * /home/nsavard/proj/chameleon_cvs/htdocs/widgets
    * "ERROR: Widget Definition for class 'MapDHTMLWidget' not found (tag is
<cwc2 type="MapDHTMLWidget" visible="true" width="400" height="300"
allowresize="false" marqueecolor="FF3333" marqueewidth="2" minscale="1"/>).
    * ERROR: MapDHTMLWidget has been renamed to MapDHTML. You must update your
template.

Version 2.5 and greater messages:

    * /home/nsavard/proj/chameleon_cvs/htdocs/widgets
    * "ERROR: Widget Definition for class 'MapDHTMLWidget' not found (tag is
<cwc2 type="MapDHTMLWidget" visible="true" width="400" height="300"
allowresize="false" marqueecolor="FF3333" marqueewidth="2" minscale="1"/>).

I get no MapDHTMLWidget Directory. Is this your expected result Norm?

No.  I want you to verify if you have the same messages and behaviour as I got
when changing version in chameleon.php.  Use sample_basic.phtml and MapDHTMLWidget.

Chris, reassigning to you since this is now held up by you.  I think that we can
mark this as fixed since we are now in the verification stage.

I recieved the same result as Norm in Comment #11 
Setting to Fixed in CVS.