Bug 501 – buttonizer: img id cannot start with a number

Bug 501 - buttonizer: img id cannot start with a number

Summary:

buttonizer: img id cannot start with a number

Status:	CLOSED FIXED

Product:	Chameleon
Component:	Core
Version:	1.99
Platform:	PC Windows XP

Importance:	P2 normal
Target Milestone:	1.99 beta 2
Assigned To:	Paul Spencer

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2004-07-06 03:24 by Bart van den Eijnden
Modified:	2004-07-14 16:06 (History)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Bart van den Eijnden 2004-07-06 03:24:05

The Chameleon buttonizer generates MD5 type of id's for the images. According to
W3C this is invalid, id's can never start with a number. Up until now I have not
found any problem caused by this, but it is an easy fix I guess to prefix a
letter. The same applies to the name.

--
Line 199, column 96: value of attribute "ID" invalid: "6" cannot start a name

...54ded7a095d7705021d4c92bdc9b432" id="654ded7a095d7705021d4c92bdc9b432" src="/

It is possible that you violated the naming convention for this attribute. For
example, id and name attributes must begin with a letter, not a digit.

------- Comment #1 From Paul Spencer 2004-07-07 12:04:31 -------

good catch.  The fix is to modify Button.php and CWC2ButtonCache.php to prepend
a letter (lets use "b" for button :>)

------- Comment #2 From Paul Spencer 2004-07-08 11:16:41 -------

fixed by prepending b to all button names.

To verify, clear all buttons from the button cache (/ms4w/tmp/ms_tmp/buttons)
and load an application.  No images should be generated that do not start with "b".

------- Comment #3 From Normand Savard 2004-07-13 11:08:36 -------

Verified on Fedora Core 2 Chameleon 20040709.

------- Comment #4 From Chris Thorne 2004-07-14 16:06:23 -------

verified on windows using beta 2 20040709