You need to log in before you can comment on or make changes to this bug.
Hi, The ExtractWFSData widget is not working anymore, probably because of a name clash, the error I am getting is: Fatal error: Cannot redeclare getgml() (previously declared in C:\ms4w_20 \apps\chameleon\htdocs\widgets\ExtractWFSData\ExtractWFSData.php:528) in C:\ms4w_20\apps\chameleon\htdocs\widgets\LayerAttributes.php on line 822
Bill, please take care of this one.
FIxed in cvs. Update the extractwfs widget to use the common get GML function in the LayerAttributes.php.
Hi Bill, this part works now, but the widget is still not fully functional. But this is caused by the fact that a few common directories are missing from the Chameleon 1.99 beta 1 MS4W package: common/ogr common/tar
this is because they are missing from the makefile, I've updated the makefile and the next release will have it :)
Currently I am verifing bugs for the release of beta 2. Bill, can you take a look at this or comment on this bug. I tried to use the WFSExtract in the sample application, the popup worked, but when pushing the extract button, nothing! http://localhost/chameleon/samples/sample_ogc.phtml Was this the problem you had?
Chris, Bart has just committed a change to the ExtractWFSData widget. It now requires .../common/zip/zip.php. Can you please update your php_utils and include this file and let me know if the problem still happens?
Also, the ExtractWFSData widget has got a new required attribute now, called compressionformats. The tools_ogc.html and the tools_roi.html templates in the samples directory need to be changed. <cwc2 type="ExtractWFSData" styleresource="NavButton" visible="true" image="/ms4w_20/apps/chameleon/htdocs/images/tool_extract_off.png" imagetip="Download shapefile of GML" imagewidth="24" imageheight="24" popupwidth="450" popupheight="300" toolbar="false" status="false" menubar="false" outputformats="Shape,GML" compressformats="ZIP,TGZ" > <image state="normal"/> <image state="hover"/> </cwc2> See bug 367 for more info.
Sorry bill, I am unable to test your latest CVS update, since I have been given a specific beta 2 version from paul. This bug will still be set to reopened until paul decides to either set this new fix to beta 3 target or creates a new build of beta 2.
Why is compressformats a required attribute? It seems to me that it would be better to simply assume no compression if the attribute is not set?
That's a possibility Daniel, would require a few changes though. As both GML and shapefiles compress well, it seemed a good idea to me to "encourage" the user to download the content compressed. Let me know which way you guys want to proceed, and I'll make the changes if necessary.
Daniel, this was an oversight in the design. The original requirements for the widget were to download a compressed verion, the decision was made at design time to allow the user to download the uncompressed format if they wanted. As Bart said, it would require a number of changes. This is because the compression format is firmly tied to the GUI. I do agree that it could be made an optional component.
target beta 3 for testing. Bart, are you going to address the changes in functionality described above?
Paul, I will probably do the changes somewhere next week.
Bart, have you committed the changes for this widget? We are into a final round of bug fixes for beta 3.
The way the code is implemented right now, the compression and output formats are specified as sub-tags in the widget declaration which is cool. There is no way to make subtags mandatory except to produce an error in the widget code (i.e. the framework won't choke on it) I notice that there are reasonable default choices for compression and output formats (zip/tgz and gml/shape). I don't think having a choice for no compression is a good idea unless you are selecting GML ... and getting into different compressions for different formats is not something we are going to address right now. I am going to mark this bug as fixed because the main issue in this bug is addressed and working. If the features need to change, then an enhancement bug can be filed describing how the widget should be changed.
Changed target for verification to 1.99 RC 1.
Paul, the changes were committed indeed, sorry I did not update the bug report after this. Also, I am just working through my e-mails after being on holiday until 19th of October, so that explains my slow response :)
*** Bug 417 has been marked as a duplicate of this bug. ***
