Bug 107 - [TemplateParser] implement code review comments
: [TemplateParser] implement code review comments
Status: CLOSED FIXED
: Chameleon
Core
: 1.99
: All All
: P3 normal
: 1.99 beta 2
Assigned To:
:
:
:
:
:
  Show dependency treegraph
 
Reported: 2003-11-12 14:58 by
Modified: 2004-07-05 17:15 (History)


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2003-11-12 14:58:29
Code Review held 2003-11-12 for TemplateParser.php

add mnElements member variable
modify constructor to take pattern
modify constructor to take ref to object providing GetTemplate()
add comment for constructor
add @return comment to Parse
modify LoadTemplate -> SetTemplate
modify Parse to remove CWC-specific stuff (use moTemplateLoader->GetTemplate())
modify Parse to set mnElements at the end
modify ParseCallback to use array_push rather than count()
remove replace none mode from ProcessPatternReplacement (i.e. index 0 is the
first element instead of 1)
replace GLOBALS with member variables in preg_callback
change name of preg_callback to ProcessPatternReplacementCallback
change NumElements() to use member variable
add GetTemplate method as per documentation
add class comment for CWCTemplateParser
change CWCTemplateParser constructor to accept object, pass object and pattern
to parent constructor
------- Comment #1 From 2004-04-08 08:35:43 -------
updated version to 1.99
------- Comment #2 From 2004-04-16 09:50:05 -------
working on this now
------- Comment #3 From 2004-04-16 10:02:06 -------
working on this now.
------- Comment #4 From 2004-04-21 07:43:58 -------
this is implemented and committed and seems to work fine in all existing apps
that I have tried.
------- Comment #5 From 2004-06-22 17:22:20 -------
Can someone from the code review group verify this bug. Thanks
------- Comment #6 From 2004-06-24 11:01:44 -------
change target for verification beta 2
------- Comment #7 From 2004-06-24 11:02:41 -------
change target for verification beta 2
------- Comment #8 From 2004-07-05 17:15:14 -------
verified.