You need to log in before you can comment on or make changes to this bug.
Code Review held 2003-11-12 for TemplateParser.php add mnElements member variable modify constructor to take pattern modify constructor to take ref to object providing GetTemplate() add comment for constructor add @return comment to Parse modify LoadTemplate -> SetTemplate modify Parse to remove CWC-specific stuff (use moTemplateLoader->GetTemplate()) modify Parse to set mnElements at the end modify ParseCallback to use array_push rather than count() remove replace none mode from ProcessPatternReplacement (i.e. index 0 is the first element instead of 1) replace GLOBALS with member variables in preg_callback change name of preg_callback to ProcessPatternReplacementCallback change NumElements() to use member variable add GetTemplate method as per documentation add class comment for CWCTemplateParser change CWCTemplateParser constructor to accept object, pass object and pattern to parent constructor
updated version to 1.99
working on this now
working on this now.
this is implemented and committed and seems to work fine in all existing apps that I have tried.
Can someone from the code review group verify this bug. Thanks
change target for verification beta 2
verified.