Bug 110 - [Chameleon] Code Review - Widget.php
: [Chameleon] Code Review - Widget.php
Status: NEW
: Chameleon
Core
: 1.99
: PC Windows XP
: P3 normal
: FUTURE
Assigned To:
:
:
: CodeReview
:
:
  Show dependency treegraph
 
Reported: 2003-11-13 09:54 by
Modified: 2015-05-18 17:50 (History)


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2003-11-13 09:54:11
Date: 2003-11-14 10AM

Participants: Paul, Daniel, Bill, Norm?, Sacha
------- Comment #1 From 2003-11-13 15:03:51 -------
This is core stuff and I would like to replace Norm with Assefa since he wrote
important parts of Widget.php.  So the list of participants becomes: Paul,
Daniel, Bill, Assefa, Sacha

Norm can participate in code review of higher level stuff later on if he wants.
------- Comment #2 From 2003-11-14 11:48:49 -------
Widget.php version 1.43  2003-11-05

* update copyright
* @author tag needs review
* comment priority defines
* change priority defines to integers (and other defines)
* naming conventions for priorities?  use numbers? make proposal to
dev@dmsolutions.ca.  Definitely remove PRIORITY_GOD
* what is AUTO_PROJECTION_UNIT needed for?  Should Widget contain ReprojectAuto
function?
* class comment needs details, including example .. .abstract base class
* group member variables more logically
* comment at least some of the member variables
* moApp should be mroApp
* look for other member variables that are references
* need to consider implications on changing member variable names.
* should put comments around member variables for public, private
* update comment for constructor
* need to ensure that $lang is validated somewhere
* initialize language stuff to null if not used?
* move oCommonMLT into Chameleon.php and access via moApp
* in ValidateAttributes, change foreach to a for loop. 
* in ValidateAttributes, change double to single quotes
* ValidateAttributes needs a comment
* SetMap should be SetMapRef and comment should reflect it.  Consider renaming
to mroMapSession, .... also, document that it is a MapSession object.
* change to SetSharedResouceWidgetsRef, fix comments
* change to SetURLRef and fix comments
* ParseURL comment should describe return value
* SetUniqueId fix comments

continue on Monday ...
------- Comment #3 From 2004-04-05 16:28:06 -------
need to restart this one I think, to be finished for 1.99
------- Comment #4 From 2004-04-08 08:35:32 -------
updated version to 1.99
------- Comment #5 From 2004-06-24 10:37:30 -------
changing target to "-", since "1.99 beta release" is no longer valid, since it
is to general.

Paul and Darren should decide at which point during the beta release cycle this
should be resolved.
------- Comment #6 From 2004-06-24 10:59:04 -------
changing target to "-", since "1.99 beta release" is no longer valid, since it
is to general.

Paul and Darren should decide at which point during the beta release cycle this
should be resolved.
------- Comment #7 From 2004-06-24 10:59:20 -------
changing target to "-", since "1.99 beta release" is no longer valid, since it
is to general.

Paul and Darren should decide at which point during the beta release cycle this
should be resolved.
------- Comment #8 From 2004-11-03 16:13:06 -------
to be completed for RC1
------- Comment #9 From 2004-12-20 13:58:42 -------
This still needs to be done but I don't think it is as critical for 2.0 ...
targetting future.