Bug 797

interesting.  Cariad reported a similar issue to me when I was fixing another
bug for her application.  The problem was intermittent for her, for some reason.
 I've tried this locally on windows with no problem, I can't reproduce.  The
code reads:

if ($szFileName == '')
{
    if (!isset( $http_form_vars["file_name"] ) ||
trim($http_form_vars["file_name"]) == "" )
    {
        echo "file id not set or empty";
        exit;
    }

$szFileName is set if SESSION['DOWNLOADFILE'] is set.  The DownloadContext
widget sets this session variable before loading the download.phtml file.  So
this error should not be occurring.  Norm, can you investigate this further by
dumping the contents of $_GET and $_SESSION where the error is triggered in
download.phtml (line 149) by adding:

print_r($_GET);
print_r($_SESSION);

and also adding an echo "here!"; on line 131 to see if the code is going into
that section.

No problem Paul.  I will do that as soon as I complete investigating another
issue.

Changed target to 1.99 RC 1.

Paul, I added the lines to output variable values.  I got no PHP output.  I only
see the message "here" I added in the popup.  Here is a snippet of the code I
modified.

----------------------
Code snippet:


   ....

$http_form_vars = (count($_POST) > 0) ?
$_POST : ((count($_GET) > 0) ? $_GET : array() );

$szFileName = '';
$szSaveAs = '';
$szURL = '';

if (isset($_GET['sid']))
{
    include_once( 'session.inc.php' );
    
    if (isset($_SESSION['DOWNLOADFILE']))
        $szFileName = $_SESSION['DOWNLOADFILE'];
    if (isset($_SESSION['DOWNLOADFILE_SAVEAS']))
        $szSaveAs = $_SESSION['DOWNLOADFILE_SAVEAS'];
    if (isset($_SESSION['DOWNLOAD_URL']))
        $szURL = $_SESSION['DOWNLOAD_URL'];
        
echo "here!";
     unset($_SESSION['DOWNLOADFILE']);
     unset($_SESSION['DOWNLOADFILE_SAVEAS']);
     unset($_SESSION['DOWNLOAD_URL']);
}

//make sure file_name is set.
if ($szFileName == '')
{
    if (!isset( $http_form_vars["file_name"] ) ||
trim($http_form_vars["file_name"]) == "" )
    {
        echo "file id not set or empty";
        exit;
    }
    else
        $szFileName = trim($http_form_vars["file_name"]);

    //download it
    $szSaveAs = ((isset($http_form_vars['save_as'])) ?
$http_form_vars['save_as'] : basename( $file_name ));

print_r($_GET);
print_r($_SESSION);


    //make sure file_name is valid

   ....

I have the same issue with SLD.

Steps to reproduce:

1.  Load "sample_ogc.phtml"
2.  Select "Tools" tab
3.  Open "world" context
4.  Click on "OpenSLD" button
5.  Type in the following URL for SLD:
http://www2.dmsolutions.ca/msapps/world_testdata/tests/sld_tests/sld_line_width.xml

6.  Click "Ok"
7.  Click the "SaveSLD" button
8.  Click the "Save SLD" button
9.  Same message "here!file id not set or empty"

Both functionalities go through the same code (logic)

I guess I'll need to fix this since I broke it ;)

fixed in cvs.  Turns out that you need to call session_write_close(); before
issuing a header() directive to redirect the page IF you have made changes in
the session.  This affected all widgets that download stuff.  download.phtml was
also made much more restrictive, it now enforces use of session variables to set
the download file rather than allowing it via the url.