|
| Summary: | [Chameleon] Code Review - TemplateParser.php | ||
|---|---|---|---|
| Product: | Chameleon | Reporter: | Paul Spencer <pspencer@dmsolutions.ca> |
| Component: | Core | Assignee: | Paul Spencer <pspencer@dmsolutions.ca> |
| Status: | CLOSED FIXED | ||
| Severity: | normal | CC: | chameleon-dev@lists.maptools.org, inmate08@mail.ru |
| Priority: | P3 | Keywords: | CodeReview |
| Version: | 1.99 | ||
| Target Milestone: | 1.99 beta 2 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
action items: add mnElements member variable modify constructor to take pattern modify constructor to take ref to object providing GetTemplate() add comment for constructor add @return comment to Parse modify LoadTemplate -> SetTemplate modify Parse to remove CWC-specific stuff (use moTemplateLoader->GetTemplate()) modify Parse to set mnElements at the end modify ParseCallback to use array_push rather than count() remove replace none mode from ProcessPatternReplacement (i.e. index 0 is the first element instead of 1) replace GLOBALS with member variables in preg_callback change name of preg_callback to ProcessPatternReplacementCallback change NumElements() to use member variable add GetTemplate method as per documentation add class comment for CWCTemplateParser change CWCTemplateParser constructor to accept object, pass object and pattern to parent constructor
need to fix the action items for 1.99.
updated version to 1.99
implemented. These issues have affected chameleon.php, TemplateProcessor.php and UIManager.php so please look out for any side effects (I tested in several applications using a variety of widgets and template replacements but not with template includes)
can someone from this code review verify this, thanks.